Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new hook to determine the loading interval for entities pages #4068

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

bjoernricks
Copy link
Contributor

What

Add new hook to determine the loading interval for entities pages

Why

Add a useEntitiesReloadInterval hook to replace in conjunction with the useReload hook the Reload component. useEntitiesReloadInterval calculates the timeout for the next reload and useReload actually calls a function after this timeout to allow reloading data.

References

HOCless entities pages

Checklist

  • Tests

@bjoernricks bjoernricks requested a review from a team as a code owner June 13, 2024 14:12
@bjoernricks bjoernricks enabled auto-merge (rebase) June 13, 2024 14:12
Copy link

github-actions bot commented Jun 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c824a2f.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@bjoernricks bjoernricks force-pushed the use-entitites-reload-interval branch from 47162b0 to d5db22c Compare June 13, 2024 14:14
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.26%. Comparing base (12f9e5c) to head (c824a2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4068      +/-   ##
==========================================
+ Coverage   72.25%   72.26%   +0.01%     
==========================================
  Files        1064     1065       +1     
  Lines      121658   121710      +52     
  Branches     6002     6011       +9     
==========================================
+ Hits        87899    87951      +52     
  Misses      33728    33728              
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add a useEntitiesReloadInterval hook to replace in conjunction with the
useReload hook the Reload component. useEntitiesReloadInterval
calculates the timeout for the next reload and useReload actually calls
a function after this timeout to allow reloading data.
@bjoernricks bjoernricks force-pushed the use-entitites-reload-interval branch from d5db22c to c824a2f Compare June 14, 2024 08:31
@bjoernricks bjoernricks merged commit 7213041 into main Jun 17, 2024
13 checks passed
@bjoernricks bjoernricks deleted the use-entitites-reload-interval branch June 17, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants